Support RBS signature aliases #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
added
enhancement
andyw8
changed the title
andyw8
force-pushed
the
andyw8/support-method-aliases
branch
from
a1cf814 to
574795c
Compare
andyw8
commented
Jul 24, 2024
st0012
reviewed
Jul 24, 2024
vinistock
approved these changes
Jul 25, 2024
andyw8
commented
Jul 25, 2024
st0012
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2329
Presumably to reduce duplication, RBS uses aliases to indicate that two methods have the same signature.
Implementation
Handle using a
Entry::UnresolvedMethodAliasAutomated Tests
Added.
Manual Tests
Not sure we can currently...